Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41029 )
Change subject: soc/intel/jasperlake: Allow SataEnable to be filled from devicetree
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG@9
PS4, Line 9: it
it to 1
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG@10
PS4, Line 10: controller
Dot/period after *controller*.
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG@11
PS4, Line 11: it can be set as per each board's requirement.
1. Why can’t this be detected at run-time?
2. What is the the disadvantage of always enabling it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f7e7508b8cd483508293ee3e7b760574d8f025f
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 May 2020 17:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment