Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35077 )
Change subject: security/vboot: Decouple measured boot from verified boot
......................................................................
Patch Set 63:
Hi Patrick, can you clarify your concern? Do you think this approach is somehow less reliable than the previous one? If VBOOT is enabled, then all of coreboot is verified (and therefore trusted) anyway, so I don't see how it makes a difference at what point exactly in coreboot we're writing the hashes to the TPM. If VBOOT isn't enabled, you can't trust any of the code and a malicious bootblock/verstage could have extended bad hashes already. In essence this is not doing anything that the older version didn't already do for bootblock and verstage, it's just doing that for romstage and ramstage as well because it greatly simplifies the design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb376b4a8b98baffaee4d574937797bba1f8aee
Gerrit-Change-Number: 35077
Gerrit-PatchSet: 63
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Comment-Date: Thu, 13 Feb 2020 20:15:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment