[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/baseboard: Set PCH Thermal Trip value to 75 ...

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/baseboard: Set PCH Thermal Trip value to 75 degree C
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/1/src/mainboard/google/hatch/... 
PS1, Line 114: 		device pci 12.0 off end # Thermal Subsystem
> It's used to program a register in the corresponding PCI device. […]

We are using this register under chip soc/intel/cannonlake. So, I would prefer to use this above (at the same place) compared to here, if there are no other benefit.