build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43439 )
Change subject: mb/google/volteer: Add GPIO configuration table for terrador
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43439/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/43439/3/src/mainboard/google/voltee...
PS3, Line 61: PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1), /* I2S2_SCLK */
code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43439/3/src/mainboard/google/voltee...
PS3, Line 61: PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1), /* I2S2_SCLK */
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/43439/3/src/mainboard/google/voltee...
PS3, Line 61: PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1), /* I2S2_SCLK */
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id22e50e3da3e2dc4ee4d01a4f71d8f651a0dcb32
Gerrit-Change-Number: 43439
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 12:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment