Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46491 )
Change subject: sec/intel/txt: Move DPR size to Kconfig ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46491/1/src/security/intel/txt/Kcon... File src/security/intel/txt/Kconfig:
https://review.coreboot.org/c/coreboot/+/46491/1/src/security/intel/txt/Kcon... PS1, Line 35: "DMA Protected Region size in MiB" I'm not sure if this should be user configurable? On Haswell you don't have a choice so having this visible can lead to potentially bad checks. On systems where you can configure it, this value will probably be used to configure it. You want this to have some sane value, defined in the SOC Kconfig so also here it does not seem to be a good idea to expose it.
https://review.coreboot.org/c/coreboot/+/46491/1/src/security/intel/txt/Kcon... PS1, Line 36: range 0 255 Heh, I was not aware this existed ^^