Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35032 )
Change subject: timestamps: Improve collection for ENV_ROMSTAGE_OR_BEFORE ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35032/5/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/35032/5/src/arch/x86/car.ld@69 PS5, Line 69: _car_ehci_dbg_info_end = .;
We're also moving the location of ehci info in this patch to be outside of relocatable window. […]
Done
https://review.coreboot.org/c/coreboot/+/35032/3/src/include/timestamp.h File src/include/timestamp.h:
https://review.coreboot.org/c/coreboot/+/35032/3/src/include/timestamp.h@28 PS3, Line 28: * it's up to the chipset/arch to call timestamp_init() in the former stages.
This doesn't really make it clear anymore that it should only be called in *one* of those stages (li […]
Done
https://review.coreboot.org/c/coreboot/+/35032/5/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35032/5/src/soc/intel/fsp_broadwell... PS5, Line 108: timestamp_init(get_initial_timestamp());
Put these changes in another patch? Also add some comments as to why this should be placed here.
Done