Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48305 )
Change subject: soc/amd: factor out common family 17h&19h TSC and monotonic timer code ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Could consider putting under block/cpu instead of a new block.
Eventually we could also point other devices to use similar code, with different decoding of the p-state register, and subject to the various limitations (e.g. Stoney's TSC frequency changes after a ucode patch, and IIRC Kyõsti had measured some differences in Family 14h and Family 16h). But, I'm not sure whether that might change your Kconfig symbol.
good idea. i've updated the patch and added a patch in between to prepare soc/amd/common/block/cpu for this
https://review.coreboot.org/c/coreboot/+/48305/1/src/soc/amd/common/block/ts... File src/soc/amd/common/block/tsc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48305/1/src/soc/amd/common/block/ts... PS1, Line 7:
we can't use that for verstage on psp. […]
there is currently no guard for that and i don't think that we should add clutter to coreboot-common code due to verstage on psp slightly breaking some assumptions