Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: variants
variants -> var
Done
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: support new touch : panel ic
Keep it in single line. […]
Done
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@10 PS3, Line 10: This is a new G2Touch screen IC, enable touch screen, : and ensure it works properly.
Add devicetree configuration for G2TOUCH Touchscreen controller.
Done
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
Since this comment is not resolved, I am re-opening it.
Yes, Thanks for Macro & Karthik's reminder and reply.
1. disable_gpio_export_in_crs back to the CL. --> done. 2. double confirm on vendor spec & vendor,
70ms is provided by the vendor based on past experience. After checking the spec, this value is not recorded in the datasheet.
I refer to other models that also use the 50ms setting, which is corrected to 50ms.