Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 32:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui... PS30, Line 83: &&
Should be "||".
Done
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... PS32, Line 33: void Change the type to 'struct params_data' in case the caller passes the wrong type.
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... PS32, Line 42: void Change the type to 'struct params_data' in case the caller passes the wrong type.