Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge
......................................................................
Patch Set 2:
Patch Set 2:
(108 comments)
Way too many stoney or stoneyridge. I hope I found them all.
This patch is an _exact_ copy of stoneyridge, where the only difference (see the commit message) is that Makefile.inc is renamed. In this way, it's easy to review the changes that are made to it as it transforms into a working picasso. The alternative is to simply drop in a brand new directory where it's unreasonable to ask anyone to review it.
Well, at least path such as soc/amd/... has to be fixed. Also, I believe, family must be fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6809bd1eea304f76dd9000c079b3ed09f94dbd3b
Gerrit-Change-Number: 32407
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 01 Jul 2019 16:55:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment