Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51007 )
Change subject: nb/intel/sandybridge/pcie.c: remove disable NOP ......................................................................
nb/intel/sandybridge/pcie.c: remove disable NOP
The .disable function pointer is only referenced inside set_vga_bridge_bits() and is used to unset VGA decoding on the internal GFX device.
Change-Id: I6888b08ac11ba2431601fa179d063cee0bb93370 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/51007 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/pcie.c 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/pcie.c b/src/northbridge/intel/sandybridge/pcie.c index d0b7fd5..36e9f26 100644 --- a/src/northbridge/intel/sandybridge/pcie.c +++ b/src/northbridge/intel/sandybridge/pcie.c @@ -7,12 +7,6 @@ #include <device/pci_ids.h> #include <assert.h>
-static void pcie_disable(struct device *dev) -{ - printk(BIOS_INFO, "%s: Disabling device\n", dev_path(dev)); - dev->enabled = 0; -} - #if CONFIG(HAVE_ACPI_TABLES) static const char *pcie_acpi_name(const struct device *dev) { @@ -56,7 +50,6 @@ .enable_resources = pci_bus_enable_resources, .scan_bus = pciexp_scan_bridge, .reset_bus = pci_bus_reset, - .disable = pcie_disable, .init = pci_dev_init, .ops_pci = &pci_dev_ops_pci, #if CONFIG(HAVE_ACPI_TABLES)