[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ability to disable Heci1

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )

Change subject: soc/intel/cannonlake: Add ability to disable Heci1
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/#/c/32992/13/src/soc/intel/cannonlake/fsp_params... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/32992/13/src/soc/intel/cannonlake/fsp_params... 
PS13, Line 344:  !CONFIG(SOC_INTEL_COMETLAKE)
> I am a bit confused about the two ways of disabling Heci1: […]

As i know CNL is not using FSP's way to make HECI disable, as this is not requested and timeline doesn't matches. Now do we know if WHL and CNL is using same FSP then, my understanding is wrong.

In general CNL and ICL will use SMM way to make HECI disable and WHL, CFL and CML should use FSP ways to make HECI disable