Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47340 )
Change subject: src/soc/intel/denverton_ns: Use improvement in coreboot since 4.9
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: Code-Review+1
There are issues with setting NEM on Denverton platform reliable.
FSP-CAR works correctly and reliable so it the suggested method to setup CAR.
NEM could be removed in the future.
Um, no. If coreboot CAR init isn't working well on Denverton, the expected approach is to investigate why. Given that APL uses CQOS, maybe that's what DNV should also be using instead?
To be clear. In the past I`ve only deeply checked setting temp ram using FSP-T TempRamInit call. And can confirm that this methods works correctly and is reliable on DNV. So my suggestion to use it instead of others.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc5ce91118c6052af23642fb3461f574cd888dea
Gerrit-Change-Number: 47340
Gerrit-PatchSet: 3
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 19:01:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment