Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36682 )
Change subject: [WIP]soc/intel/car: Add support for bootguard CAR
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36682/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/36682/1/src/soc/intel/common/block/...
PS1, Line 26: #define BOOTGUARD_MSR 0x13a
move that to msr.h?
https://review.coreboot.org/c/coreboot/+/36682/1/src/soc/intel/common/block/...
PS1, Line 33: setups up it's
nit: sets up its
https://review.coreboot.org/c/coreboot/+/36682/1/src/soc/intel/common/block/...
PS1, Line 482: put
out
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifac5267f8f4b820a61519fb4a497e2ce7075cc40
Gerrit-Change-Number: 36682
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 08 Nov 2019 18:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment