[coreboot-gerrit] Change in ...coreboot[master]: usbdebug: Fix reserve in CAR

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31174 )

Change subject: usbdebug: Fix reserve in CAR
......................................................................

Patch Set 2:

(1 comment)

Aaron, Julius; there is a bit of dilemma with car.ld.

1) We need consistent layout across PRE_RAM stages
2) We want RO bootblock, unaware of (future) RW romstage requirements
3) I don't like the semi-random size reserve, like done here for usbdebug

Any ideas how to from improve this? Looking at CONFIG_COMMONLIB_STORAGE and CONFIG_PAGING_IN_CACHE_AS_RAM, I am not sure if the fixed locations are always maintained properly. There is some strong assumption at least, that bootblock and romstage are built with same set of Kconfig options set.

https://review.coreboot.org/#/c/31174/1/src/arch/x86/car.ld 
File src/arch/x86/car.ld:

https://review.coreboot.org/#/c/31174/1/src/arch/x86/car.ld@70 
PS1, Line 70:         . += 0x60;
> yes

Done