Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75613?usp=email )
Change subject: [WIP] acpi/acpigen: avoid truncating length in acpigen_resource_producer_io
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I guess this could also be handled with DWordIO() or even QWordIO() (?!?)
i've never seen this in any vendorcode i looked at. windows didn't dislike it, but linux disliked it; see the commit message of patchset 2.
since this isn't needed for the rest of the patches, i'll mark this patch as WIP. i'm still undecided if the first or the second patchset should be the way to go; might also help if i ask one of our kernel engineers to look into this if he has some time for that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a59cdfcfa30a8fdd13f8db3dc1447994c266c8b
Gerrit-Change-Number: 75613
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Sat, 03 Jun 2023 01:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
