Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )
Change subject: mb/google/kukui: Add panels for Krane ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33413/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33413/3//COMMIT_MSG@7 PS3, Line 7: google/krane: Add Panel auo kd101n80-45na support
Add panel AUO kd101n80-45na support
Ack
https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... PS9, Line 44: boe_tv101wum_nl6
Hi Jitao, this panel model is TV101WUM-NL6, correct? Thanks a lot!
Ack
https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... PS15, Line 36: INIT_DCS_CMD, 1, {0x11}
Not super happy about having to match the size here manually. […]
Done
https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... PS15, Line 357: static struct panel_description *krane_panels[] = {
We should split these into a separate CBFS file each like we have for SDRAM params. […]
let's do that later when we find this really needed. for now most boards will only have 2 panels that I think putting them into CBFS is not a high priority thing...