Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35762 )
Change subject: sb/intel/ibexpeak: Implement USB current settings ......................................................................
Patch Set 10: Code-Review+2
(5 comments)
https://review.coreboot.org/c/coreboot/+/35762/9/src/mainboard/packardbell/m... File src/mainboard/packardbell/ms2290/romstage.c:
https://review.coreboot.org/c/coreboot/+/35762/9/src/mainboard/packardbell/m... PS9, Line 90: early_usb_init(mainboard_usb_ports);
Pass ARRAY_SIZE() as call argument, test for equals TOTAL_USB_Ports? Same for snb/ivy? […]
Declaring it with fixed size is already better, although it leaves the possibility of having too few elements. As long as zero-initialised entries don't cause permanent damage, it's fine like your follow-up work does it.
We can revisit this later.
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_usb.c:
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 38: 14
magic?
Done
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 51: 14
magic!
Done
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 56: 8
more magic!
Done
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 66:
Double space
Done