Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39631 )
Change subject: nb/intel/sandybridge: Use loops on DMI register groups
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39631/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39631/4//COMMIT_MSG@10
PS4, Line 10: "per-lane" or "per-bundle"
Wouldn't it be better to use these names (lane and bundle) as variables in the loops?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebf40b2a5b37ed9060a6660840ea6cdff7eb3fc3
Gerrit-Change-Number: 39631
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Mar 2020 09:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment