Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59026 )
Change subject: soc/amd/cezanne: Use LZ4 for FSP-S ......................................................................
soc/amd/cezanne: Use LZ4 for FSP-S
This change increases the fsps.bin by 20 KiB, but it decreases decompression time. When not using preloading we save about 6 ms, when using preloading we save about 8.
BUG=b:179699789 TEST=Boot nipperkin to OS Using FSP-S preload: | 30 - device enumeration | 2.073 | 2.312 Δ( 0.24, 0.02%) | | 971 - loading FSP-S | 6.628 | 7.227 Δ( 0.60, 0.04%) | | 17 - starting LZ4 decompress (ignore for x86) | 0.01 | 0.01 Δ( 0.00, 0.00%) | | 18 - finished LZ4 decompress (ignore for x86) | 8.316 | 0.241 Δ( -8.08, -0.55%) | | 954 - calling FspSiliconInit | 0.09 | 0.089 Δ( -0.00, -0.00%) |
Not using prealod: | 30 - device enumeration | 2.092 | 2.527 Δ( 0.44, 0.03%) | | 971 - loading FSP-S | 6.567 | 6.565 Δ( -0.00, -0.00%) | | 17 - starting LZ4 decompress (ignore for x86) | 0.008 | 0.008 Δ( 0.00, 0.00%) | | 18 - finished LZ4 decompress (ignore for x86) | 15.165 | 8.998 Δ( -6.17, -0.40%) | | 954 - calling FspSiliconInit | 0.037 | 0.038 Δ( 0.00, 0.00%) |
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ib0479ed3c92158799ea2b023bd2ce4c5c09757dd --- M src/soc/amd/cezanne/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/59026/1
diff --git a/src/soc/amd/cezanne/Kconfig b/src/soc/amd/cezanne/Kconfig index 6af0abb..fc0173a 100644 --- a/src/soc/amd/cezanne/Kconfig +++ b/src/soc/amd/cezanne/Kconfig @@ -21,7 +21,7 @@ select DRIVERS_I2C_DESIGNWARE select DRIVERS_USB_PCI_XHCI select FSP_COMPRESS_FSP_M_LZMA - select FSP_COMPRESS_FSP_S_LZMA + select FSP_COMPRESS_FSP_S_LZ4 select GENERIC_GPIO_LIB select HAVE_ACPI_TABLES select HAVE_CF9_RESET