Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32542 )
Change subject: mb/siemens/mc_apl2: Limit SD-Card speed to DDR50 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 47: dev = dev_find_slot(0, PCH_DEVFN_SDCARD); Would pcidev_path_on_root(PCH_DEVFN_SDCARD) work here instead?
There are some aspects of dev_find_slot() why I would like to see it deprecated. One of them is that not only does the 'slot' aka 'dev' section of the PCI path BDF has to match, but also the '.fn' part.
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 55: write32(base + SD_CAP_BYP, SD_CAP_BYP_EN); Looks like arithmetics performed on void pointer. AFAIR this is GCC extension not in the C standard but I don't remember if we generally approve or disapprove these.