Attention is currently required from: Michał Żygowski, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343 )
Change subject: security/vboot: Add function to clear recovery request
......................................................................
Patch Set 3:
(1 comment)
File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/74343/comment/c741c521_66e506f4
PS3, Line 31: save_vbnv
I'd suggest (also see my comment in CB:74402) just transforming this function into a boot state hook that's not called by anything else and just does it's thing (clear recovery reason and safe vbnv) at the end of ramstage in one go.
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617
Gerrit-Change-Number: 74343
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 17 Apr 2023 03:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment