Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email )
Change subject: arch/arm64: Support calling a trusted monitor ......................................................................
Patch Set 13:
(2 comments)
File src/arch/arm64/include/armv8/arch/smc.h:
https://review.coreboot.org/c/coreboot/+/78284/comment/938d47ba_f1bd6914 : PS13, Line 8: static inline u Sorry, this one can't be static inline. I'm actually surprised the compiler doesn't complain about that. A function should either be static inline and then have the function body right there in the header file (like smc_call3() here), or it should be just declared as a prototype like this and then be neither static nor inline.
File src/arch/arm64/smc.c:
https://review.coreboot.org/c/coreboot/+/78284/comment/44355721_dd6bc58f : PS11, Line 10: inline uint64_t smc_call(uint32_t function_id, uint64_t arg1, uint64_t arg2, uint64_t arg3,
I actually found that other boards broke if this file was compiled unconditionally. […]
I just meant putting smc_call() into the header and leaving smc() as it was. But I'm fine with just getting rid of the assert() as well (the Makefile ifeq will already take care of that, essentially).