Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38647 )
Change subject: drivers/intel/gma/edid: Directly assign 32-bit value ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38647/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38647/2//COMMIT_MSG@13 PS2, Line 13: are made, showing that some instructions are saved. Why not use the reference toolchain?
https://review.coreboot.org/c/coreboot/+/38647/2//COMMIT_MSG@49 PS2, Line 49: jmp .L12 The diff doesn't provide much value, imho. If you want to keep it, it would be much more readable with the comments removed, just `objdump -d` should do it.
https://review.coreboot.org/c/coreboot/+/38647/2/src/drivers/intel/gma/edid.... File src/drivers/intel/gma/edid.c:
https://review.coreboot.org/c/coreboot/+/38647/2/src/drivers/intel/gma/edid.... PS2, Line 18: #include <swab.h> Not used anymore.
https://review.coreboot.org/c/coreboot/+/38647/2/src/drivers/intel/gma/edid.... PS2, Line 93: /* Only works on LE systems, writes 4 * i to (4 * i) + 3 */ It's much more complicated. I would have said the old code only works with LE.