Attention is currently required from: Bill XIE, Jérémy Compostella, Nico Huber.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email )
Change subject: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS4:
Sorry, I don't see how this makes things better. It adds […]
Thanks for the context Nico, good to be aware of that.
I think we should go ahead with patchset #5 also. Differentiating S3 wakeup for this behavior sounds too subtle / coincidental to me, maybe applying the GM45 behavior too broadly, and not clear that it would solve the unknown behavior of other boards that might have cmos.layout fields outside of the checksum.
In my opinion there's no need for any more complexity unless we have specific examples that warrant it. So IMO, either we try to identify boards with cmos.layout fields outside of the checksum (not sure this is worth that amount of effort), or we try this change given that we think they probably would have problems already.