Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35014/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/1/src/include/rules.h@280 PS1, Line 280: )
Why was ENV_RMODULE dropped here?
I got it wrong and need to but it back :/
https://review.coreboot.org/c/coreboot/+/35014/1/src/include/rules.h@280 PS1, Line 280: ENV_RAMSTAGE
Shouldn't this be ENV_PAYLOAD_LOADER to keep it the same as before this change?
With RAMPAYLOAD=y you would just add heap section without malloc() for postcar. I am not so confinced if we should add postcar-y += malloc.c, but that's not the scope here.
See late CB:32725 commentary.