Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 )
Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49291/comment/45ad524a_0d9773c6
PS2, Line 11: enable
enabled
Ack
https://review.coreboot.org/c/coreboot/+/49291/comment/d9d7e8a9_91ca76e5
PS2, Line 13: Pre-OS
pre-OS
Ack
https://review.coreboot.org/c/coreboot/+/49291/comment/a7f2cb6e_238bcac0
PS2, Line 14: DGPU when mainboard user selects ENABLE_DISPLAY_OVER_DGPU.
What payload is used?
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49291/comment/5ec0256d_6ca10286
PS2, Line 192: #if CONFIG(ENABLE_DISPLAY_OVER_DGPU)
Hah, it would be nice if it worked, but these are just comments in the devicetree 😉
Ack
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/49291/comment/8c72eedf_720a7dbb
PS2, Line 247: def_bool n
This doesn't have a prompt.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58
Gerrit-Change-Number: 49291
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 12:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment