Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39766 )
Change subject: drivers/i2c/nct7802y: configure local temp sensor
......................................................................
Patch Set 30: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/c...
File src/drivers/i2c/nct7802y/chip.h:
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/c...
PS30, Line 68: enum nct7802y_sensor_mode rtd1;
Nit, we use arrays, usually.
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/n...
File src/drivers/i2c/nct7802y/nct7802y.h:
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/n...
PS30, Line 15: #define MODE_SELECTION_EN_LTD(x) (x << 6)
Nit, if it's a single bit, it doesn't need a parameter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28cc4e5cae76cf0bcdad26a50ee6cd43a201d31e
Gerrit-Change-Number: 39766
Gerrit-PatchSet: 30
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 27 Sep 2020 18:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment