[coreboot-gerrit] Change in coreboot[master]: soc/intel/{common,skl,cnl,icl,apl,tgl}: Move HFSTS1 register definiti...

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35546 )

Change subject: soc/intel/{common,skl,cnl,icl,apl,tgl}: Move HFSTS1 register definition to SoC
......................................................................

Patch Set 27:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35546/25/src/soc/intel/common/block... 
File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/35546/25/src/soc/intel/common/block... 
PS25, Line 54: /* ME Host Firmware Status register 1 */
             : union me_hfsts1 {
             : 	u32 data;
             : 	struct {
             : 		u32 working_state: 4;
             : 		u32 mfg_mode: 1;
             : 		u32 fpt_bad: 1;
             : 		u32 operation_state: 3;
             : 		u32 fw_init_complete: 1;
             : 		u32 ft_bup_ld_flr: 1;
             : 		u32 update_in_progress: 1;
             : 		u32 error_code: 4;
             : 		u32 operation_mode: 4;
             : 		u32 reset_count: 4;
             : 		u32 boot_options_present: 1;
             : 		u32 reserved1: 1;
             : 		u32 bist_test_state: 1;
             : 		u32 bist_reset_request: 1;
             : 		u32 current_power_source: 2;
             : 		u32 d3_support_valid: 1;
             : 		u32 d0i3_support_valid: 1;
             : 	} __packed fields;
             : };
> Yes, it make sense, and implemented the code accordingly.

Done