Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52896 )
Change subject: soc/amd/common/fsp/fsp-acpi: factor out SSDT from HOB functionality ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/fsp/fsp-acpi.c:
https://review.coreboot.org/c/coreboot/+/52896/comment/e92cf9b4_078a2f9c PS1, Line 18: add_agesa_fsp_acpi_table
Should we add alib into the name and drop the name parameter? This no longer searches for specific t […]
this is a generic function to add a ssdt from a hob. i'm not sure what you mean with "searches for specific tables"; it finds the table by the guid of the hob. sure, i don't expect that we need to add another ssdt that gets passed from the fsp to coreboot via a hob, but this isn't alib specific. the alib-specific part is passed as parameters to the call in agesa_write_acpi_tables. for an example how that can grab another hob and process it into a ssdt, see the line of code that got removed in this patch https://review.coreboot.org/c/coreboot/+/47727/6/src/soc/amd/picasso/agesa_a...