Attention is currently required from: Felix Singer, Jon Murphy, Karthik Ramasubramanian, Martin L Roth.
Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85275/comment/4e010415_5a9ada93?usp... :
PS13, Line 867: mkdir -p gcc/$TARGETARCH && \
:
: # shellcheck disable=SC2086
```suggestion
mkdir -p gcc/$TARGETARCH && \
# shellcheck disable=SC2086
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed
Gerrit-Change-Number: 85275
Gerrit-PatchSet: 13
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 21:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes