Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 18:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 41: 0xFFFFFFFF
If you use lower case here, it'll match coreboot better than AMD's style.
Done
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 48: /* patch authentication */
had another look at the PPR and this is indeed a check if the new microcode update got applied, whic […]
Done. Deleted.
https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... File src/soc/amd/picasso/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... PS17, Line 84: if (equivalent_processor_rev_id == 0) { : printk(BIOS_DEBUG, "microcode: rev id not found. Skipping microcode patch!\n"); : return; : }
unneeded check, since the lookup table is gone
Done. Deleted.
https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... PS17, Line 92: BIOS_DEBUG
I'd rather use BIOS_WARNING or BIOS_INFO here
Done. Changed.