Hello Kyösti Mälkki, Angel Pons, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34531
to look at the new patch set (#2).
Change subject: mb/purism/librem_skl: use SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
mb/purism/librem_skl: use SOC_INTEL_COMMON_BLOCK_HDA_VERB
Remove old hda_verb.c code copied from intel/kblrvp7, as it's been superseded by the common block HDA implementation.
Fixes a null pointer error preventing the HDA codecs from being initialized, as found in Coverity CID 1403651.
Test: build/boot Librem 13v2, verify functional audio
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I2fd5363aad027f215f93964bc6a85f00fea86c88 --- M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_skl/hda_verb.c D src/mainboard/purism/librem_skl/hda_verb.h 3 files changed, 45 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34531/2