Attention is currently required from: Xi Chen, Martin Roth. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49634 )
Change subject: mb/google/asurada: Add byte mode sdparam config ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/asurada/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/49634/comment/cfb294a6_54592ee7 PS1, Line 12: [0x01] = "sdram-lpddr4x-MT29VZZZAD8GQFSL-046-4GB", : [0x02] = "sdram-lpddr4x-KMDP6001DA-B425-4GB", : [0x03] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", these are 4GB emCP 2x2, so I think we can keep then in group 0x0 below.
https://review.coreboot.org/c/coreboot/+/49634/comment/ea1a2e38_e5ce0bd8 PS1, Line 98: [0x61] = "sdram-lpddr4x-DISCRETE-2RANK-8GB-BYTE-MODE", : [0x62] = "sdram-lpddr4x-DISCRETE-2RANK-8GB-BYTE-MODE", no, we don't want to mix two settings in one group, because the key is we want to assign DRAMs without changing firmware code.
Please check with alvis - maybe we'll want to do group 6 = normal, group 7 = byte.