build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40930 )
Change subject: acpi: Move all ACPI table support out of arch/x86 ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1596 PS1, Line 1596: case SSDT: /* ACPI 3.0 upto 6.3: 2 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1598 PS1, Line 1598: case SRAT: /* ACPI 2.0: 1, ACPI 3.0: 2, ACPI 4.0 upto 6.3: 3 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1602 PS1, Line 1602: case SLIT: /* ACPI 2.0 upto 6.3: 1 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1614 PS1, Line 1614: case FACS: /* ACPI 2.0/3.0: 1, ACPI 4.0 upto 6.3: 2 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1616 PS1, Line 1616: case RSDT: /* ACPI 1.0 upto 6.3: 1 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1618 PS1, Line 1618: case XSDT: /* ACPI 2.0 upto 6.3: 1 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi.c@1620 PS1, Line 1620: case RSDP: /* ACPI 2.0 upto 6.3: 2 */ 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi_device.c File src/acpi/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi_device.c@141 PS1, Line 141: * so should not be called mulitple times in one statement 'mulitple' may be misspelled - perhaps 'multiple'?
https://review.coreboot.org/c/coreboot/+/40930/1/src/acpi/acpi_device.c@530 PS1, Line 530: static const char *power_res_dev_states[] = { "_PR0", "_PR3" }; static const char * array should probably be static const char * const