[coreboot-gerrit] Change in coreboot[master]: payloads/ipxe: Enable HTTPS support

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31086 )

Change subject: payloads/ipxe: Enable HTTPS support
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/31086/3/payloads/external/iPXE/Make... 
File payloads/external/iPXE/Makefile:

https://review.coreboot.org/c/coreboot/+/31086/3/payloads/external/iPXE/Make... 
PS3, Line 57: 	sed -ie 's|.*DOWNLOAD_PROTO_HTTPS|#define DOWNLOAD_PROTO_HTTPS|g' "$(project_dir)/src/config/general.h"
> Ah, that about GNU sed wasn't right. It creates […]

Ack

https://review.coreboot.org/c/coreboot/+/31086/4/payloads/external/iPXE/Make... 
File payloads/external/iPXE/Makefile:

https://review.coreboot.org/c/coreboot/+/31086/4/payloads/external/iPXE/Make... 
PS4, Line 56: 	sed 's|.*DOWNLOAD_PROTO_HTTPS|#define DOWNLOAD_PROTO_HTTPS|g' "$(project_dir)/src/config/general.h" > "$(project_dir)/src/config/general.h"
> This reading from / redirecting to the same file is not supposed to work. […]

Ack