Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34616 )
Change subject: soc/intel/cnl: Only print ME status one time
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me...
File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me...
PS1, Line 302:
Ok, changed to BS_OS_RESUME_CHECK, ON_EXIT. […]
It doesn't look like that happens. But I remember, from cold boot, the FSP disables HECI. So if it gets re-enabled sometime in S3 suspend/resume, it's probably still running and would need to be disabled again. Separate issue?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86bc6e33de4096f33023730ffabb25715c985de0
Gerrit-Change-Number: 34616
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jul 2019 20:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment