[coreboot-gerrit] Change in coreboot[master]: herobrine: get boardid from GPIO configuration

[Shelley Chen (Code Review)]

Attention is currently required from: Ravi kumar, Paul Menzel, Ravi Kumar Bokka.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55950 )

Change subject: herobrine: get boardid from GPIO configuration
......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/herobrine/boardid.c:

https://review.coreboot.org/c/coreboot/+/55950/comment/1a08116a_fb3f4bfb 
PS5, Line 25: CB_ERR
> hi shelly, […]

Yes, you are correct actually.  But, I just realized that if we don't match one of the boards, it is actually not an error, but we just don't recognize it.  So, I believe that the correct action is to return the retrieved boardid anyway and perhaps print out that it was not recognized.