Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39221 )
Change subject: vboot: Clean up pre-RAM use of vboot_recovery_mode_enabled()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/mrc_cache/mrc_c...
PS2, Line 522: if (!CONFIG(VBOOT_STARTS_IN_BOOTBLOCK))
These checks seem out of place and seem to be providing new semantics to the modules themselves. i.e. unless STARTS_IN_BOOTBLOCK=true then we don't support the paths that we used to. Isn't that leaking abstractions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31bfc7663724fdacab9955224dcaf650d1ec1c3c
Gerrit-Change-Number: 39221
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 03 Mar 2020 00:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment