Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37261 )
Change subject: security/vboot: Use persistent context to read GBB flags
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37261/1/src/security/vboot/misc.h
File src/security/vboot/misc.h:
https://review.coreboot.org/c/coreboot/+/37261/1/src/security/vboot/misc.h@5...
PS1, Line 58: bool
Are we doing bools now? I have only ever seen int used for booleans up until this point.
Depends on the repository. coreboot has had bools for a while, libpayload still doesn't have them. I'm just copying the signature from the previous code here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc3ed0f3fbeb53d630925d47df4dc474b0ed07ee
Gerrit-Change-Number: 37261
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment