Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86582?usp=email )
Change subject: soc/amd/common/block/lpc: Limit ROM2 to 16MiB
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/86582/comment/7f3ac32c_ad4f9ec8?usp... :
PS1, Line 280: if (CONFIG_COREBOOT_ROMSIZE_KB <= 16384)
nit:
add comment like:
```
limit the mapping to a maximum of 16MiB.
```
https://review.coreboot.org/c/coreboot/+/86582/comment/ce4234bc_49441020?usp... :
PS1, Line 284: pci_write_config16(_LPCB_DEV, ROM_ADDRESS_RANGE2_START, 0xff00);
nit:
I guess you could also write:
```
pci_write_config16(_LPCB_DEV, ROM_ADDRESS_RANGE2_START, 0x10000 - (MIN(CONFIG_COREBOOT_ROMSIZE_KB, 16384) >> 6));
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86582?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie811f6a38363f2e900611b3f3f407a94d8137c89
Gerrit-Change-Number: 86582
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No