Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )
Change subject: soc/apollolake: Generate DMAR table
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30990/6/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/systemagent.h:
https://review.coreboot.org/#/c/30990/6/src/soc/intel/apollolake/include/soc...
PS6, Line 37: #define VTBAR_MASK 0xfffff000
This should be extended to support the full 64-bit (actually
40-bit) value. e.g. `0xfffffff000ull` or `(~0xfffull)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3683a2f3578c141c691b2268e32f27ba2e772fa
Gerrit-Change-Number: 30990
Gerrit-PatchSet: 6
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 14:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment