[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor S3 helpers

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )

Change subject: soc/amd/common: Refactor S3 helpers
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/31490/6/src/soc/amd/common/block/pi... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/c/coreboot/+/31490/6/src/soc/amd/common/block/pi... 
PS6, Line 318: 	if (OemS3Save(&RtbParams->S3DataBlock) != AGESA_SUCCESS)
> I believe the spec has to do with systems where memory DIMM can be changed. […]

Memory training data is also useful on cold boots: if the memory is the same, why waste time retraining the same thing again?