Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )
Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp...
PS4, Line 206: GPIO_WAKE_STATUS
This will be taken care of in the event logging change to ensure that we snapshot the state before g […]
I think we'd be able to log (eventlog) things w/ b/159947207 once that work is done, but it doesn't handle the case of the kernel expecting to capture the wake. If we want to note the device that woke from kernel we shouldn't clear these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f
Gerrit-Change-Number: 42877
Gerrit-PatchSet: 8
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 22:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment