14 Mar
2022
14 Mar
'22
9:54 p.m.
Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Tim Wawrzynczak. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 )
Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62330/comment/a3f5d586_9a44d84d PS10, Line 213: rp6_wwan
I like your PCIe generic approach better. […]
Is there additional work needed for this CL? If not, can we resolve this comment so that this CL can merge?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Cliff Huang cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 14 Mar 2022 20:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment