Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster.
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@7
PS2, Line 7: google/kukui: Increase SPI flash speed to boot faster.
Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@11
PS2, Line 11:
1. Please add hard numbers how much faster it now boots.
2. Why 56 MHz and not higher?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a
Gerrit-Change-Number: 32462
Gerrit-PatchSet: 2
Gerrit-Owner: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 May 2019 15:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment