[coreboot-gerrit] Change in ...coreboot[master]: vboot: refactor OPROM code

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )

Change subject: vboot: refactor OPROM code
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig 
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 
PS7, Line 180: and any other native display initialization code is not run
> Yeah, I just added that there recently... […]

I'm not sure if anybody still builds vboot with these old platforms.
For Haswell, libgfxinit is the only alternative to VGA_ROM_RUN for
some time. But you are probably right, maybe nobody who uses it cares.
I guess it would be best to make MUST_REQUEST_DISPLAY the default
(unless a platform really requires it to run unconditionally, e.g.
OS can't bring it up). I'll try to keep that in mind if I touch the
code again :)