Attention is currently required from: Patrick Rudolph, Subrata Banik, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49176 ) Change subject: [WIP]device/Kconfig: Introduce separate graphics menu for Intel ...................................................................... Patch Set 2: (3 comments) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/49176/comment/e24724be_5e913487 PS1, Line 79: such as the Google Link This is crying for an update ;) https://review.coreboot.org/c/coreboot/+/49176/comment/4eac727a_bdeeeac3 PS1, Line 98: bool "None" This should eventually be renamed, e.g. "Device specific drivers only". Because the selection in the device-specific choices would overrule this one. https://review.coreboot.org/c/coreboot/+/49176/comment/41b63721_7bbece69 PS1, Line 134: VGA_ROM_RUN_INTEL
CB:31449 CL is good as it creates dedicated Kconfig for DGPU with VBIOS as part of CBFS but how do w […] Well, both this and the VGA_ROM_RUN option don't depend on files in CBFS. It's only the default that is hard to achieve. But I don't see a problem: Subrata's CB:49016 allows a mainboard to let VGA_ROM_RUN default to `y` for DGPUs. This choice is for IGPUs and independent.
E.g. one can select MAINBOARD_USE_LIBGFXINIT in this choice for an IGPU and still have VGA_ROM_RUN for the DGPU. -- To view, visit https://review.coreboot.org/c/coreboot/+/49176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410fecfdb8a99ca520b2c05edd9ed2558d7e0a92 Gerrit-Change-Number: 49176 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Attention: Subrata Banik <subrata.banik@intel.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Fri, 08 Jan 2021 16:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com> Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment