Attention is currently required from: Saurabh Mishra, Tarun Tuli, Subrata Banik, Kapil Porwal.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69961 )
Change subject: vendorcode/intel/edk2/edk2-stable202111: Update MdePkg/Include/IndustryStandard/SmBios.h
......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69961/comment/795f1eaa_35691e33
PS4, Line 7: Update MdePkg/Include/IndustryStandard/SmBios.h
Please be more specific.
https://review.coreboot.org/c/coreboot/+/69961/comment/72faa145_8648096d
PS4, Line 7: vendorcode
vc
https://review.coreboot.org/c/coreboot/+/69961/comment/33aa7d52_65d3a0b2
PS4, Line 8:
Please start by describing the problem.
https://review.coreboot.org/c/coreboot/+/69961/comment/112bd46d_d459ca12
PS4, Line 9:
Please use only one space.
https://review.coreboot.org/c/coreboot/+/69961/comment/1d605b5e_8d0296ac
PS4, Line 9: '
Remove.
https://review.coreboot.org/c/coreboot/+/69961/comment/fd1938c3_bdfa74df
PS4, Line 13: Changes include:
Not needed.
https://review.coreboot.org/c/coreboot/+/69961/comment/80f0a83c_5674727f
PS4, Line 15: Kconfig.
Safe guard enum macro with ….
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69961
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc65d05a8b4bd232b91184ff8cd52a20cd3538ae
Gerrit-Change-Number: 69961
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Vikrant Jadeja
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 11:50:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment