[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Sync fsp upd structure update

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31131 )

Change subject: soc/intel/apollolake: Sync fsp upd structure update
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31131/1/src/soc/intel/apollolake/chip.h 
File src/soc/intel/apollolake/chip.h:

https://review.coreboot.org/#/c/31131/1/src/soc/intel/apollolake/chip.h@173 
PS1, Line 173: Set
             : 	 * value to change IF value for successful Chrome OS installation
Let's not put mainboard specific comment in common code. Instead can you add details to indicate what are valid values for ModPhyIfValue?

https://review.coreboot.org/#/c/31131/1/src/soc/intel/apollolake/chip.h@185 
PS1, Line 185: Set value for Vdd2 voltage with 1.24v.
What are the valid values?